Jordan Birdsell has posted comments on this change.

Change subject: KUDU-854 - [python] Expose additional scanner projection methods
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4344/2/python/kudu/schema.pyx
File python/kudu/schema.pyx:

Line 327:         fluid programming style. This method allows the SchemaBuilder 
to be
> typo
Done


Line 328:         more easily used to build a new Schema from an existing one.
> period at the end
Done


http://gerrit.cloudera.org:8080/#/c/4344/2/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:

Line 100:     def test_index_projection_with_schema(self):
> seems like these should be two different tests (even 2 different patches)
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to