Will Berkeley has posted comments on this change.

Change subject: Add release notes for tablet history GC
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3988/4/docs/release_notes.adoc
File docs/release_notes.adoc:

PS4, Line 41: ,
            : that
Happened to notice this typo. Probably want
"releases. Applications using" or "releases: applications using"


PS4, Line 109: Kudu will
             :   remove changes that were only visible prior to the ancient 
history mark, but
             :   not anymore
Maybe we need an evocative adjective to indicate "changes to the row that 
aren't part of the most recent / current state of the row"? Is "stale" clear 
enough? e.g. "Kudu will remove changes to the row that are stale and that date 
from before the ancient history mark". Could also define stale in a nearby 
sentence. Am I understanding what it's removing correctly? The term "visible" 
is confusing me because, to me, the state of the row at any point in the past 
is visible, in the sense I can ask for it and Kudu can give it to me, until 
there's some GC like this.


-- 
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to