Jordan Birdsell has posted comments on this change.

Change subject: [python] Implement Scan Token API
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4367/5/python/kudu/tests/test_scantoken.py
File python/kudu/tests/test_scantoken.py:

Line 35:         Stolen from the the test scanner given the similarity in
> Stolen & Similarity are mispelled
Done


Line 77:         builder = self.table.scan_token_builder()
> It looks like this line and below is repeated for the three tests, could yo
Cant move it to _get_scan_token_results since I need to serialize the tokens in 
the main thread before shipping to the new threads. However, I did create a 
helper function within the class to clean this up a bit.


http://gerrit.cloudera.org:8080/#/c/4367/5/python/requirements.txt
File python/requirements.txt:

Line 6
> This is a test-only dependency, right?  Is there anyway to express that wit
Good point, i moved this to setup.py in the tests_require list.


-- 
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to