Dan Burkert has posted comments on this change.

Change subject: [python] Implement Scan Token API
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4367/5/python/kudu/tests/test_scantoken.py
File python/kudu/tests/test_scantoken.py:

Line 77:         input = self._package_input(builder.build())
> Cant move it to _get_scan_token_results since I need to serialize the token
beyond just creating the tokens, it looks like spinning up the thread pool, 
collecting results, and comparing against the expected set is all in common.  
Could that all be collapsed together?


-- 
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to