Adar Dembo has posted comments on this change.

Change subject: tool: port ts-cli
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4373/3/src/kudu/tools/ksck_remote.cc
File src/kudu/tools/ksck_remote.cc:

Line 265:   builder.default_rpc_timeout(GetDefaultTimeout());
> is this worth mentioning in commit-message or just a cleanup ?
I'll add a note to the commit message.


http://gerrit.cloudera.org:8080/#/c/4373/3/src/kudu/tools/tool_action_tserver.cc
File src/kudu/tools/tool_action_tserver.cc:

PS3, Line 69: Change a gflag value on a Kudu Tablet Server
> Extending this with an example flag could be useful.
I'm going to punt on this for now. We don't use examples in other actions, and 
this is already far better documentation than what existed before in ts-cli.


http://gerrit.cloudera.org:8080/#/c/4373/3/src/kudu/tools/tool_main.cc
File src/kudu/tools/tool_main.cc:

Line 117:     .AddMode(BuildMasterMode())
> We could have made 'tablet' as a sub-mode of this actually given that the c
I too prefer deeper nesting, but others (Todd, Dan) have expressed a preference 
for more top-level modes and less nesting. So we'll need to reach some sort of 
consensus; for now we'll be a bit top-heavy.


-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to