David Ribeiro Alves has posted comments on this change.

Change subject: [client] performance optimizations
......................................................................


Patch Set 2:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4385/2//COMMIT_MSG
Commit Message:

Line 10: which gave about 50% boost while running in scenario when
Is there a test that you can point to that demonstrates this speed up? Any real 
numbers you can post here?


http://gerrit.cloudera.org:8080/#/c/4385/2/src/kudu/client/batcher.cc
File src/kudu/client/batcher.cc:

Line 481
can you move this warning to the ctor? (or to the caller of the ctor)


http://gerrit.cloudera.org:8080/#/c/4385/2/src/kudu/client/client.cc
File src/kudu/client/client.cc:

Line 761:     : data_(new KuduSession::Data(client, client->data_->messenger_)) 
{
spurious change


http://gerrit.cloudera.org:8080/#/c/4385/2/src/kudu/client/session-internal.cc
File src/kudu/client/session-internal.cc:

Line 446:     // Thread-safety note: the buffer_bytes_limit_ and
nit: rewrap to use whole lines


Line 448:     // from any other thread of control since no thread-safety is 
advertised
what's a "thread of control"?


Line 450:     // So, no protection while accessing those members.
Actually can you move this (and the comment on loc 338) to where the field is 
declared?


http://gerrit.cloudera.org:8080/#/c/4385/2/src/kudu/client/session-internal.h
File src/kudu/client/session-internal.h:

Line 160:   sp::weak_ptr<KuduSession> session_;
doc


-- 
To view, visit http://gerrit.cloudera.org:8080/4385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b57fc7355f9f673f30861ec30cb6b48cdf656d2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to