Alexey Serbin has posted comments on this change.

Change subject: [client] performance optimizations
......................................................................


Patch Set 2:

(1 comment)

Thank you for the review!  Will address the rest of the comments after 
addressing the tests flakiness issue.

http://gerrit.cloudera.org:8080/#/c/4385/2//COMMIT_MSG
Commit Message:

Line 10: which gave about 50% boost while running in scenario when
> Is there a test that you can point to that demonstrates this speed up? Any 
Yes, there is.  I implemented a test which resembles InserLoadgen from 
java-examples, and this is what I'm using for performance comparison in this 
scenario.  Will post it for review soon.

As for the real numbers, I got the following when running that test on  
ve0518.halxg.cloudera.com, 1 thread, 8M rows per thread:

Before the changes:
-> buffer space: 32MiB
-> buffers num : 2
-> flush_every_n_rows: 2000
  total  : 22470.3 ms
  per row: 0.00280879 ms

After the changes:
  total  : 11913.5 ms
  per row: 0.00148918 ms


-- 
To view, visit http://gerrit.cloudera.org:8080/4385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b57fc7355f9f673f30861ec30cb6b48cdf656d2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to