Andrew Wong has posted comments on this change.

Change subject: Blogpost describing predicate evaluation pushdown
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4384/3/_posts/predicate-pushdown.md
File _posts/predicate-pushdown.md:

PS3, Line 83: ends
> Nit: "end" (plural)
Done


PS3, Line 113: Full
> Nit: should be "All" to correspond with the graph.
Done


http://gerrit.cloudera.org:8080/#/c/4384/4/_posts/predicate-pushdown.md
File _posts/predicate-pushdown.md:

PS4, Line 82: when there are too many unique values to fit in a dictionary, 
performance
            : suffers
> Thank you for the explanation.  So, the talk here is about building and mai
I think it might be enough to clarify that the dictionary block switches to 
"plain encoding mode" rather than switching to a plain-encoded block.
Right, this here is referring to building and maintaining the dictionary/bitset 
for the first blocks, and then not using them thereafter, as the dictionary 
blocks would all be "plain encoding mode" blocks that don't utilize the 
codewords.


PS4, Line 144:  to 1.0
> I would just drop 'to 1.0', but if the original intention was to emphasize 
That's fair. I put this in expecting this to be posted after 1.0, which would 
be another pretty big milestone to note. If that ends up being the case, I 
think I'll leave it.


-- 
To view, visit http://gerrit.cloudera.org:8080/4384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3b593959194a6ce9190f562339dc04a1d8fceba
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Andrew Wong <anjuw...@g.ucla.edu>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <anjuw...@g.ucla.edu>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to