Todd Lipcon has submitted this change and it was merged.

Change subject: test_main: avoid signals for timeout handling
......................................................................


test_main: avoid signals for timeout handling

Previously we used setitimer() to trigger test timeouts after the
appropriate delay. However, this caused the timeout code to run in a
signal handler, which TSAN flagged as unsafe because it allocates
memory.

This changes it to just use its own thread which sleeps before aborting
the process after the prescribed timeout.

The resulting behavior should be the same, though will avoid a bunch of
confusing spew in TSAN builds that time out.

Change-Id: I0af2485c14db366a409ba1409fa01314396d030a
Reviewed-on: http://gerrit.cloudera.org:8080/4415
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <aser...@cloudera.com>
---
M src/kudu/util/test_main.cc
1 file changed, 17 insertions(+), 34 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0af2485c14db366a409ba1409fa01314396d030a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to