Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros
......................................................................


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4417/3/python/kudu/client.pyx
File python/kudu/client.pyx:

PS3, Line 1743: # Leave it to 
> Nit: extra whitespace here and the next two lines.
Done


http://gerrit.cloudera.org:8080/#/c/4417/3/python/kudu/libkudu_client.pxd
File python/kudu/libkudu_client.pxd:

PS3, Line 217: Status GetInt32(Slice& col_name, int3
> Nit: could you do me a favor and reorganize these so either all the name-ba
Done


http://gerrit.cloudera.org:8080/#/c/4417/3/python/kudu/tests/common.py
File python/kudu/tests/common.py:

PS3, Line 167: 'unixtime_micro
> Nit: rename to unixtime_micros_val or something. There may eventually be a 
Done


http://gerrit.cloudera.org:8080/#/c/4417/3/python/kudu/tests/test_scantoken.py
File python/kudu/tests/test_scantoken.py:

PS3, Line 173: 
> Is there a test_util.py or something where this duplicated block of code co
Done


http://gerrit.cloudera.org:8080/#/c/4417/3/python/kudu/util.py
File python/kudu/util.py:

PS3, Line 75: if isinstance(unixtime_micros, int):
> Missing else?
oops, done


-- 
To view, visit http://gerrit.cloudera.org:8080/4417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to