Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4431

to review the following change.

Change subject: csd: also use master_address for --rpc_bind_address
......................................................................

csd: also use master_address for --rpc_bind_address

If set, master_address is an alias of some sort for the master, used in the
distributed master Raft configuration as well as in the tserver's
--tserver_master_addrs gflag. Thus, it should also be used as the master's
--rpc_bind_address gflag.

Note: I'm not sure whether this change makes sense. For one,
webserver_interface is still its own parameter; maybe it should be removed
and master_address used there too? For two, how will all of this interact
with multi-homed machines, or machines where different interfaces are used
for different purposes?

Change-Id: Ibc9f0be27b134bcfd3625f0cd2ba2bb85928f8d4
---
M java/kudu-csd/src/descriptor/service.sdl
M java/kudu-csd/src/scripts/kudu.sh
2 files changed, 9 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/4431/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc9f0be27b134bcfd3625f0cd2ba2bb85928f8d4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to