Adar Dembo has posted comments on this change.

Change subject: [c++client] added TestAutoFlushBackgroundDropSession
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4432/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

PS1, Line 2431: its pending data should not be flushed.
Are you sure these are the semantics we want? They make sense for MANUAL_FLUSH 
but in AUTO_FLUSH_BACKGROUND don't we want the  session to linger in memory 
until all pending operations have been flushed?

I mean, knowing how it's implemented, I understand why this is the case, but I 
just wonder whether these are the desired semantics.


PS1, Line 2433: due
Nit: due to


-- 
To view, visit http://gerrit.cloudera.org:8080/4432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If136872a4200e18acbb587276fed28975afe3810
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to