Todd Lipcon has posted comments on this change.

Change subject: csd: also use master_address for --rpc_bind_address
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4431/1/java/kudu-csd/src/scripts/kudu.sh
File java/kudu-csd/src/scripts/kudu.sh:

Line 110:     RPC_BIND_ADDRESSES="--rpc_bind_addresses=$MASTER_ADDRESS"
not 100% sure this is always a good idea, either. For one, this means it won't 
listen on localhost anymore, which is potentially annoying when trying to run 
CLI tools from the master machine, right?


Line 126:     --tserver_master_addrs="$MASTER_IPS" \
a little odd we have MASTER_ADDRESSES, MASTER_ADDRESS, and MASTER_IP variables 
all accessed by this script. Worth renaming some for clarity?


-- 
To view, visit http://gerrit.cloudera.org:8080/4431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc9f0be27b134bcfd3625f0cd2ba2bb85928f8d4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to