Adar Dembo has posted comments on this change.

Change subject: [client-test] faster TestFlushModesCompareOpRates*
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4437/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

PS1, Line 2269:   ASSERT_OK(session->SetMutationBufferFlushWatermark(0.5));
              :   ASSERT_OK(session->SetMutationBufferMaxNum(2));
> Yes, they are.  My concern was to have this test working even if we change 
I think it's fine to keep.


-- 
To view, visit http://gerrit.cloudera.org:8080/4437
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d260ac87b2daecbc97803a4663e80978b65b8f1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to