Adar Dembo has posted comments on this change.

Change subject: [tools]: Keep the verbosity of CLI at FATAL and above
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc
File src/kudu/tools/tool_main.cc:

PS1, Line 215:     google::SetCommandLineOption("minloglevel",
             :                                  
SimpleItoa(google::GLOG_FATAL).c_str());
             :   }
             :   return show_help;
             : }
             : 
             : int main(int argc, char** argv) {
             :   bool show_help = ParseCommandLineFlags(&argc, &argv);
             :   F
> 1. Done.
No, we wouldn't have to show _all_ gflags help. Imagine that the root mode had 
'v' and 'minloglevel' defined as parameters. Then, every mode and action below 
the root would expose 'v' and 'minloglevel' in its help (probably with a little 
message explaining that it's inherited from a mode and where it came from). 
That's about it.


http://gerrit.cloudera.org:8080/#/c/4447/3/src/kudu/tools/tool_main.cc
File src/kudu/tools/tool_main.cc:

PS3, Line 215:     google::SetCommandLineOption("minloglevel",
             :                                  
SimpleItoa(google::GLOG_FATAL).c_str());
Can this just be:

  FLAGS_minloglevel = google::GLOG_FATAL;

Provided you DECLARE_int32(minloglevel) at the top of the file?


-- 
To view, visit http://gerrit.cloudera.org:8080/4447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I882a340d4c1d205e4e998c888f487b7185000e3c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to