Todd Lipcon has posted comments on this change.

Change subject: [tools]: Keep the verbosity of CLI at FATAL and above

Patch Set 1:

(1 comment)
File src/kudu/tools/

PS1, Line 215:   // Set the verbosity of the commands to WARNING(2) and above.
             :   // If the user had explicitly specified verbosity, then user's
             :   // verbosity level is honored. Since '--v' depends on 
             :   // specifying either of them on CLI will override this setting.
             :   if 
(google::GetCommandLineFlagInfoOrDie("minloglevel").is_default &&
             :       google::GetCommandLineFlagInfoOrDie("v").is_default) {
             :     google::SetCommandLineOption("minloglevel",
             :   }
> It's difficult to corral INFO (and even WARNING) messages; they can come fr
I agree it's a little unusual looking, but given that many of the usages of the 
tool are for debugging, etc, I think starting with verbosity (and perhaps 
offering a standard -quiet) is better than the other way around.

As an example, if you try to run 'list_tables' against a master which is down 
right now, your commend just hangs as it generates retries. I would actually 
prefer it to be _more_ verbose here, saying that it's trying to contact a 
server and getting Connection Refused. I'd rather have the verbosity there by 
default and if people want to silence it they can pipe or --quiet

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I882a340d4c1d205e4e998c888f487b7185000e3c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <>
Gerrit-Reviewer: Adar Dembo <>
Gerrit-Reviewer: Alexey Serbin <>
Gerrit-Reviewer: David Ribeiro Alves <>
Gerrit-Reviewer: Dinesh Bhat <>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <>
Gerrit-HasComments: Yes

Reply via email to