Todd Lipcon has posted comments on this change.

Change subject: Add a basic .clang-tidy configuration
......................................................................


Patch Set 1:

(1 comment)

Will add some scripting in a future commit for running this locally.

http://gerrit.cloudera.org:8080/#/c/4453/1/src/kudu/.clang-tidy
File src/kudu/.clang-tidy:

Line 18: Checks:          
'-*,clang-diagnostic-*,-clang-diagnostic-unused-const-variable,readability-*,-readability-implicit-bool-cast,-readability-braces-around-statements,-readability-redundant-string-init,-readability-inconsistent-declaration-parameter-name,performance-*,google-*,-google-readability-todo,-google-readability-braces-around-statements,misc-*,-misc-unused-parameters'
> Is it possible to split this across multiple lines with backslashes or some
yea I tried for 15 minutes and failed to get it to work. I think LLVM's yaml 
parser is somewhat deficient in this regard.


-- 
To view, visit http://gerrit.cloudera.org:8080/4453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b22195b11265959768c07fb60e9f97feeba95c7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to