Dinesh Bhat has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4440/4/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: PS4, Line 251: ASSERT_STR_CONTAINS(stdout, kTableId); : ASSERT_STR_CONTAINS(stdout, kAnotherT > Is there a guarantee that the two tables will be printed in this order? Hmmm, I looked at my test output and another cluster output where I had 4 tables, and they seem to be ordered alphabetically. However, after looking at ListTables/CreateTable service handlers in catalog_manager they are using std::unordered_map which doesn't guarantee anything about ordering of the keys in the map. For safety purposes, I am removing this assumption from code. Thanks for catching that !! -- To view, visit http://gerrit.cloudera.org:8080/4440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f8e0dfb8e7ba9f67d5926199a9b831351585a7 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
