Alexey Serbin has posted comments on this change. Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4471/1/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: Line 878 > again, you removed the update of the atomic variable. How is this test stil Yep, it's passing. I thought it would be enough to call inserted_idx_.Store() after flushing the operations. I will clarify on this. Line 914 > What I'm trying to figure out is why the test didn't fail on jenkins. Are w Yes, you are right -- even without increment of the 'i' counter, the tests pass (at least in release, ASAN and TSAN configurations). >From what I can see, passing the tests with missing increment for the counter >is not surprising -- there isn't unique constraint on the second columns >(column idx 1), so there should not be an issue if the counter stays the same. > Basically, it means that counter is not crucial here. -- To view, visit http://gerrit.cloudera.org:8080/4471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieafc198609cceb5d6945a910364056d81786629a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
