Alexey Serbin has posted comments on this change.

Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4471/1/src/kudu/integration-tests/alter_table-test.cc
File src/kudu/integration-tests/alter_table-test.cc:

Line 878
> Yep, it's passing.  I thought it would be enough to call inserted_idx_.Stor
Oh, that's clear -- what happens is that all the inserts are reported in the 
very end of the AlterTableTest::InserterThread() routine/method.  So, this test 
boiled down to making a single update in the very end, and it does not update a 
single row (since 'inserted_idx' points to the next index which would be 
inserted if the test continued to run).

OK, what I will do is the following:
1.  Return back periodic flushes every 50 rows (it works with the 
AUTO_FLUSH_BACKGROUND mode as well)
2.  Check that at least one update operations is applied to the session.

Let me know if you think some more sanity checks are required.


-- 
To view, visit http://gerrit.cloudera.org:8080/4471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieafc198609cceb5d6945a910364056d81786629a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

Reply via email to