Alexey Serbin has posted comments on this change.

Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4471/3/src/kudu/integration-tests/all_types-itest.cc
File src/kudu/integration-tests/all_types-itest.cc:

Line 218:       // Set the flush threshold low so that there are flush events 
which
> grammar changes like this are subjective, we usually avoid doing them if yo
ok, that makes sense -- will return it back then.


Line 222:       // Set the major delta compaction ratio low enough so that the 
test
> I'm ambivalent whether the grammar change is justified.
Done


Line 227:       // once KUDU-1631/KUDU-1346 is fixed. It's necessary to change 
the default
> you mean KUDU-1632, not KUDU-1631. Maybe mark KUDU-1632 as a dup of KUDU-13
Done


PS3, Line 231: --consensus_max_batch_size_bytes=2097152
> have you tested that this doens't trigger the check. How big can single tab
Yes, I've tested that.  As you could see from the stack trace of the debug 
assert, it was slightly bigger than 1MiB:

request->ByteSize() <= FLAGS_consensus_max_batch_size_bytes (1168286 vs. 
1048576)
*** Check failure stack trace: ***


-- 
To view, visit http://gerrit.cloudera.org:8080/4471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieafc198609cceb5d6945a910364056d81786629a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

Reply via email to