Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Fix an NPE in KuduException ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4488/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java: PS1, Line 83: // Message is allowed to be null, so if we let it go through we'll NPE building the Status : // down the line. > Nit: second part of the sentence is self-evident. I'd just say "The message > Where do these null messages come from? InterruptedException when created via thread.interrupt has a null message. Here's another instance that's less clear: java.lang.NullPointerException at org.apache.kudu.WireProtocol$AppStatusPB$Builder.setMessage(WireProtocol.java:847) at org.apache.kudu.client.Status.<init>(Status.java:43) at org.apache.kudu.client.Status.<init>(Status.java:52) at org.apache.kudu.client.Status.IOError(Status.java:128) at org.apache.kudu.client.KuduException.transformException(KuduException.java:96) at org.apache.kudu.client.KuduSession.apply(KuduSession.java:88) at org.apache.kudu.client.ITClient$WriterThread.run(ITClient.java:240) -- To view, visit http://gerrit.cloudera.org:8080/4488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
