Adar Dembo has posted comments on this change.

Change subject: [java client] Few ITClient improvements
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4489/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java:

PS1, Line 173:   }
             : 
             :   protected List<String> scanTableToStrings(KuduTable table,
             :                                             KuduPredicate... 
predicates) throws Exception {
             :     List<String> 
> Not without some refactoring to make them accept predicates... Seems low ga
Am I missing something? Why doesn't the following work:

  KuduScanner.KuduScannerBuilder scanBuilder = 
syncClient.newScannerBuilder(table);
  for (KuduPredicate predicate : predicates) {
    scanBuilder.addPredicate(predicate);
  }
  scanBuilder.setProjectedColumnIndexes(ImmutableList.<Integer>of());
  return countRowsInScan(scanBuilder.build());


-- 
To view, visit http://gerrit.cloudera.org:8080/4489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5ddca26b66e9fc1f737aaacf98df340f0b9024
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to