Adar Dembo has posted comments on this change.

Change subject: [util] minor clean-up on kudu::Subprocess
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4502/1/src/kudu/util/subprocess.cc
File src/kudu/util/subprocess.cc:

PS1, Line 353: unique_ptr< DIR, std::function<void(DIR*)> >
Nit: remove the spaces separating the triangular brackets from other stuff 
(i.e. unique_ptr<DIR, std::function<...>> fd_dir).

Also, the compiler can't infer the second argument on its own the way it did 
when this used a shared_ptr?


PS1, Line 445:   if (state_ != kRunning) {
             :     return Status::IllegalState("Sub-process is not running");
             :   }
I don't know about this. My impression is that the intent here was to be 
symmetric w.r.t. CheckAndOffer() and other similar functions; that is, to start 
every such function with an assertion that we're in the right state. Likely 
they could be downgraded to DCHECKs though.

Same for Start().


-- 
To view, visit http://gerrit.cloudera.org:8080/4502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd058382e4519b323aebb4c992d9088496a341cc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to