Todd Lipcon has posted comments on this change.

Change subject: ensure every gflag is defined outside of a namespace
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

lgtm, not sure what the jenkins failure's about

http://gerrit.cloudera.org:8080/#/c/4505/1/src/kudu/master/master_options.cc
File src/kudu/master/master_options.cc:

Line 30: TAG_FLAG(master_addresses, stable);
> warning: sizeof() doesn't return the size of the container; did you mean .s
I guess we need a different trick to double check that FLAGS_##flag_name is 
defined. maybe sizeof(decltype(...)) would work


-- 
To view, visit http://gerrit.cloudera.org:8080/4505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to