Todd Lipcon has posted comments on this change.

Change subject: thirdparty: upgrade LLVM to 3.9.0
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4507/1/thirdparty/vars.sh
File thirdparty/vars.sh:

Line 115: # 3. Unpack the extra clang tools tarball as 
tools/clang/tools/clang-tools-extra
One thing I noticed recently is that this direction is wrong -- it should be in 
tools/clang/tools/extra I think, or else it doesn't actually build. hence we 
dont end up with clang-tidy in toolchain (my clang-tidy-bot thing is using a 
separate binary download)


-- 
To view, visit http://gerrit.cloudera.org:8080/4507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b4a19c9acb0ee76e3a27186fabb30288a28be2c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to