Todd Lipcon has posted comments on this change.

Change subject: [c++client/samples] added README for the sample
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4517/1/src/kudu/client/samples/README.adoc
File src/kudu/client/samples/README.adoc:

Line 23: * Make sure `cmake` of version at least 2.6.2 is installed on the 
system.
does the sample require this new of a cmake? in the past we actually built the 
sample using the system cmake rather than the thirdparty one.


PS1, Line 31: /tmp/client_alt_root`
doesn't seem to match what's used below


PS1, Line 37: Change the d
Change into the directory? cd into?


Line 47: cmake -G "Unix Makefiles" 
-DkuduClient_DIR=/usr/local/share/kuduClient/cmake -DCMAKE_BUILD_TYPE=release
the 'unix makefiles' is the default.

Also, does it not pick up the client from the system cmake stuff automatically? 
For some reason I thought it did.


-- 
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to