Alexey Serbin has posted comments on this change.

Change subject: c++ client: stop requiring the old gcc ABI
......................................................................


Patch Set 1:

(1 comment)

> Uploaded patch set 1.

Do you think it's worth adding -Wabi option into the clang options to emit 
warnings in case of ABI mishaps  (plus additional -Wabi-tag for GCC)?

http://gerrit.cloudera.org:8080/#/c/4515/1/docs/release_notes.adoc
File docs/release_notes.adoc:

PS1, Line 165: `C++`
nit: {cpp} could also be an option to deal with special meaning of '+' in 
AsciiDoctor format.


-- 
To view, visit http://gerrit.cloudera.org:8080/4515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia06edb8a4699fc842a2072e1edab5cfaa14c4381
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to