Dinesh Bhat has posted comments on this change.

Change subject: [misc] : Remove few more warnings
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4518/1/src/kudu/benchmarks/rle.cc
File src/kudu/benchmarks/rle.cc:

PS1, Line 94: (void)
> Why is the cast on the return value necessary if it's not being assigned an
Well, if anything it was only for making it explicitly clear to reader that the 
routine is returning something and the caller ignores it. Just saw the google 
cpp guideline, perhaps I could have been C++ish here with static_cast than 
C-style (void) ? Or shall I remove this altogether to keep consistency with 
other places ?


-- 
To view, visit http://gerrit.cloudera.org:8080/4518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89b96d52dfed6b38f17cf8cdebeed840fb32f98d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to