Alexey Serbin has posted comments on this change.

Change subject: thirdparty: split into dependency groups
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4513/1/thirdparty/build-if-necessary.sh
File thirdparty/build-if-necessary.sh:

Line 91:       CHANGED_FILE_COUNT=$(find . -cnewer $STAMP_FILE | wc -l)
Consider adding '-type f' into the find options.  If directory (especially 
which is not under the version control) appeared or get some unrelated files, 
we don't want to rebuild, right?


-- 
To view, visit http://gerrit.cloudera.org:8080/4513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I549262858f98b5ce6c78e786e8c8d8134ba2ed36
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to