Alexey Serbin has posted comments on this change.

Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers 
on /tablet-servers
......................................................................


Patch Set 10:

(2 comments)

Almost there, just 2 style nits are left.

http://gerrit.cloudera.org:8080/#/c/4450/10/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:

Line 114:       *output << "<table class='table table-striped'>\n";
style nit: it seems lines 114-117 contain tabs.  The Kudu project uses google's 
C++ style guide which prescribes using 2 spaces as indent for inter-scope 
lines: https://google.github.io/styleguide/cppguide.html#Spaces_vs._Tabs


PS10, Line 118:   
nit: an extra indent is needed to be in balance with the opening brace of the 
if() block.


-- 
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to