Dinesh Bhat has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at FATAL and above ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc File src/kudu/tools/tool_main.cc: PS1, Line 215: FLAGS_minloglevel = google::GLOG_FATAL; : } : return show_help; : } : : int main(int argc, char** argv) { : bool show_help = ParseCommandLineFlags(&argc, &argv); : FLAGS_logtostderr = true; : k > Also, --vmodule affects only the verbose logging stuff, like VLOG(), right That's correct. --v controls VLOG(LOG at lowest level, which is INFO), and minloglevel controls LOG levels and typically you would want use one of these. My understanding is that, consumers of these additional gflags are either ops/support or developers. So for these audience, keeping the knobs at more granularity(file level) might help in the long run than keeping the loglevel knobs at library. My initial intention of this change was to get rid of INFO level messages on CLI like "Opened FS with uuid: xxxx", and I am glad it led to some interesting discussions on this topic. Folks, are we concluding that we should keep the loglevels for CLI at WARNINGS and above then ? If the user explicitly specifies a loglevel via --minloglevel or --v, then we can honor that. Also, all this impacts to 'kudu' toolset alone. We also seem to be converging that we don't want to be under a contract about machine-readability of the 'kudu' output to keep the CLI more flexible. -- To view, visit http://gerrit.cloudera.org:8080/4447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I882a340d4c1d205e4e998c888f487b7185000e3c Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
