Alexey Serbin has posted comments on this change.

Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned 
tablets to a separate section
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4526/3/src/kudu/tserver/tserver-path-handlers.cc
File src/kudu/tserver/tserver-path-handlers.cc:

PS3, Line 181:   vector<scoped_refptr<TabletPeer> > live_peers;
             :   vector<scoped_refptr<TabletPeer> > tombstoned_peers;
Consider moving these closer to the place where they are used.  I.e., move them 
just before the for() cycle which populates these containers.


Line 193:   auto generate_table_header = [](const string& header,
The generate_table_header and add_table_rows are not used separately, as I see. 
 Consider joining them into one lambda function and also adding the closing 
"</table>\n" print-out.


PS3, Line 202: auto add_table_rows
See the previous comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/4526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to