Alexey Serbin has posted comments on this change. Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4529/2/src/kudu/client/client.h File src/kudu/client/client.h: PS2, Line 1710: KuduScanBatch* > Nit: in this case the argument is included in the string, in the others it' Because one can be confused a bit: in this case the deprecated function's name is the same as the function it's obsoleted by. I added the parameter type to resolve the ambiguity. I'm open to other options here; the only requirements are to report about the deprecated method, suggest the alternative method, and keep the user less frustrated by the message. http://gerrit.cloudera.org:8080/#/c/4529/2/src/kudu/client/schema.h File src/kudu/client/schema.h: PS2, Line 88: explicit > Isn't this only desirable for single-arg constructors? Since this is multi-parameter constructor with by-default values, it might happen that one-arg usage will implicitly create an object. Actually, the Tidy Bot noticed that, not me :) I'm just addressing its comments. -- To view, visit http://gerrit.cloudera.org:8080/4529 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
