Adar Dembo has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4502/2/src/kudu/benchmarks/tpch/tpch_real_world.cc File src/kudu/benchmarks/tpch/tpch_real_world.cc: PS2, Line 303: Status s = dbgen_proc->Kill(SIGKILL); : if (!s.ok()) { : LOG(WARNING) << "Failed to send SIGKILL to dbgen: " << s.ToString(); : } : s = dbgen_proc->Wait(nullptr); : if (!s.ok()) { : LOG(WARNING) << "Failed to await for dbgen exit: " << s.ToString(); : } Why aren't these fatal? That is, why not CHECK_OK(...)? http://gerrit.cloudera.org:8080/#/c/4502/2/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: PS2, Line 422: *ret = cached_rc_; If you want to allow ret to be nullptr, you should also add a check here before the assignment. -- To view, visit http://gerrit.cloudera.org:8080/4502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd058382e4519b323aebb4c992d9088496a341cc Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes