Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning

Patch Set 2:

File python/kudu/client.pyx:

Line 1305:                 "Snapshot Timestamps be greater than the unix 
> is there a way that we can return the error status returned by SetSnapshotM
We wouldn't get that far here really, the error returned otherwise is an 
overflow error b/c of the unsigned int and I didnt think that would be 
File python/kudu/tests/

Line 122:         self.snapshot_timestamp = datetime.datetime.utcnow()
> there is no guarantee that the snapshot timestamp will be in between the de
Since this op is being flushed why would it not be guaranteed? Since its 
blocking the call, would that not guarantee that the latest observed timestamp 
after the op is at least less than this "snapshot timestamp"?  I get that using 
the latest observed timestamp is probably better form but I want to make sure I 
understand, also the TestScanAtSnapshot C++ test seems to also use system time, 
so we may need to fix that as well if its an issue.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <>
Gerrit-Reviewer: David Ribeiro Alves <>
Gerrit-Reviewer: Jordan Birdsell <>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <>
Gerrit-Reviewer: Will Berkeley <>
Gerrit-HasComments: Yes

Reply via email to