Alexey Serbin has posted comments on this change.

Change subject: Implement a version migration test
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4424/3/src/kudu/integration-tests/version_migration-test.cc
File src/kudu/integration-tests/version_migration-test.cc:

Line 115:   NO_FATALS(cluster_->AssertNoCrashes());
Consider adding a check that the new cluster can start next time successfully 
as well.  I don't know the internals, but imagine the new version loads old 
data and then stores the updated data with new layout/representation.  In that 
situation, I think it's worth checking that the updated data has been written 
successfully and the next time processes start up, they can read what have been 
written.


-- 
To view, visit http://gerrit.cloudera.org:8080/4424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2831b47e6c0b644a256e1914fa495f453318e0cd
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to