Dinesh Bhat has posted comments on this change.

Change subject: Implement a version migration test
......................................................................


Patch Set 3: Code-Review+1

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4424/2//COMMIT_MSG
Commit Message:

PS2, Line 9: a simple
> I don't think there are currently any integration tests that could be repur
Yeah agree, no doubt this is a very good first step in that direction.


http://gerrit.cloudera.org:8080/#/c/4424/3//COMMIT_MSG
Commit Message:

PS3, Line 7: Implement
Would you like to specify the JIRA number as well here ?


http://gerrit.cloudera.org:8080/#/c/4424/2/src/kudu/integration-tests/external_mini_cluster.h
File src/kudu/integration-tests/external_mini_cluster.h:

Line 255:   void SetDaemonBinPath(std::string daemon_bin_path);
> I don't think that would make sense. GetBinaryPath() takes the name of a bi
Sounds good, thanks for clarifying.


http://gerrit.cloudera.org:8080/#/c/4424/2/src/kudu/integration-tests/upgrade-test.cc
File src/kudu/integration-tests/upgrade-test.cc:

Line 38
> I just copy / pasted this from linked_list-test so I think it's reasonable 
True, I think it could be reworded in the linked_list-test too, because the 
actual definition of LoadLinkedTest calls it as 'num_samples'. Also the term 
'snapshot' is sometimes context specific and tends to get overloaded in the 
code, say for eg if we had a snapshot feature for a kudu object. However, I 
don't feel strongly about this since this flag is test-specific anyways.


-- 
To view, visit http://gerrit.cloudera.org:8080/4424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2831b47e6c0b644a256e1914fa495f453318e0cd
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to