Adar Dembo has posted comments on this change.

Change subject: build: fix codegen errors when using static linkage
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4540/1/CMakeLists.txt
File CMakeLists.txt:

Line 96: set(CMAKE_ENABLE_EXPORTS true)
> Just curious: would it be a better solution if adding MODULE specifier for 
I hadn't. Here's the error I get when I do try it:

  CMake Error at CMakeLists.txt:638 (target_link_libraries):
    Target "codegen" of type MODULE_LIBRARY may not be linked into another
    target.  One may link only to STATIC or SHARED libraries, or to executables
    with the ENABLE_EXPORTS property set.

I don't really see how it'd work; IIRC it basically makes codegen a shared 
object, but one that is only opened at runtime via dlopen(). That's not what we 
want; we do want to statically link codegen into our executables.

Am I missing something?


-- 
To view, visit http://gerrit.cloudera.org:8080/4540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie803b93cfd9b5bed56ece5f24b769850b7b55b74
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to