Adar Dembo has posted comments on this change.

Change subject: [tools] added insert-generated-rows into kudu tools
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4412/11/src/kudu/tools/tool_action_test.cc
File src/kudu/tools/tool_action_test.cc:

PS11, Line 128: DEFINE_string(test_master_addresses, "localhost:7051",
              :               "Comma separated list of master addresses to run 
against; "
              :               "addresses are 'hostname:port' form, where port 
may be omitted "
              :               "if a master server listens at the default 
port.");
> Certainly, it's better to keep semantics and usage of the master_addresses 
Maybe:
1) As part of this commit, make it mandatory (to be consistent with the rest).
2) As a follow-up, if you're interested, change them all.


Line 494:       .Description(
> You mean ExtraDescription()?  OK, will do.  I'm also thinking to add exampl
Yeah, I think a couple examples aren't a bad idea. Just run "kudu test loadgen 
--help" when you're done to make sure it looks OK.


-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to