Adar Dembo has posted comments on this change. Change subject: [java client] ITClient's new snapshot scanners can easily timeout ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4545/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java: PS1, Line 416: // It's possible to get timeouts if we're unlucky. A particularly common one is : // "could not wait for desired snapshot timestamp to be consistent" since we're using : // READ_AT_SNAPSHOT scanners. : if (e.getStatus().isTimedOut()) { : LOG.warn("Received a scan timeout", e); : return true; : } > I think the problem here is that we cannot distinguish between a timeout ca But shouldn't we retry in either case? The C++ client differentiates between operation level timeouts and RPC timeouts, and at any point where an RPC times out, it'll look at the operation timeout to decide whether to retry. I'd expect the Java client to behave similarly. -- To view, visit http://gerrit.cloudera.org:8080/4545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08de2fcd6736c2bc75ef0c92c8c8f48f9d7da49e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
