Adar Dembo has posted comments on this change.
Change subject: thirdparty: split into dependency groups
Patch Set 1:
Line 29: "instrumented_msan" dependency group).
> Will this actually work for msan, though? My understanding is that msan re
You're probably right. I'm working on a follow-up patch that rebuilds the C
dependencies for TSAN too.
PS1, Line 86: #
Line 91: CHANGED_FILE_COUNT=$(find . -cnewer $STAMP_FILE | wc -l)
> Consider adding '-type f' into the find options. If directory (especially
I don't think it matters much either way. This case is so very rare (basically
for developers who are annoyed at thirdparty rebuilds when testing out of a
tarball install) that I don't think we need to optimize for a tarball whose
contents actually changes.
Line 363: build_protobuf
> hmm. I think what this is saying, is that protobuf (and the others below)
Yes, that's true, and it is something of a functional regression from before.
But, I also think it's such a rarely used feature that it's not a huge deal
either way. I only use "build-thirdparty.sh <lib>" on a fully-formed thirdparty
tree when I want to rebuild a single library.
We can certainly revisit this if there are complaints; it's relatively easy to
To view, visit http://gerrit.cloudera.org:8080/4513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>