Alexey Serbin has posted comments on this change. Change subject: [tools] introduced GetKuduCtlAbsolutePath() ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4547/1/src/kudu/tools/CMakeLists.txt File src/kudu/tools/CMakeLists.txt: Line 32: add_library(kudu_tools_util > This is a shipping library, yet tool_util.cc is test-only code. Maybe we ca Done http://gerrit.cloudera.org:8080/#/c/4547/1/src/kudu/tools/tool_util.cc File src/kudu/tools/tool_util.cc: Line 20: #ifndef KUDU_TOOLS_TOOL_UTIL_H_ > #pragma once It seems it's a copy-and-paste artifact. Will remove. http://gerrit.cloudera.org:8080/#/c/4547/1/src/kudu/tools/tool_util.h File src/kudu/tools/tool_util.h: Line 20: #ifndef KUDU_TOOLS_TOOL_UTIL_H_ > Use #pragma once instead. Done -- To view, visit http://gerrit.cloudera.org:8080/4547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
