David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4520/2/python/kudu/tests/util.py
File python/kudu/tests/util.py:

Line 122:         self.snapshot_timestamp = datetime.datetime.utcnow()
> Since this op is being flushed why would it not be guaranteed? Since its bl
because the server's clock might not have the same time as the system's clock 
(it's not a pure physical clock). i.e. the time returned by the system clock 
might behind or ahead of the time the server assigned to the write. it's 
unlikely but it can happen and thus it would make this test flaky.


-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to