Alexey Serbin has posted comments on this change.
Change subject: [tools] added insert-generated-rows into kudu tools
Patch Set 15:
PS15, Line 108: ADD_KUDU_TEST(kudu-test)
> Why not reuse kudu-tool-test, which is where all of the new CLI tests (apar
Good idea, will do. I was not sure where to put it; probably I should have
asked for an advice.
> These are nice, but can we at least verify that something was written with
The exact row count is verified by the utility itself if adding '-run_scan'
flag (this is so for all tests besides the very first one which runs with
Do you mean we want to verify the exact data which has been written? I.e.,
read it back and compare with the data which was inserted into the table?
Line 110: #include "kudu/util/random.h"
> Nit: should precee stopwatch (surprised Tidy Bot didn't mention it?)
Good catch, will update.
So, it seems there is a hope -- not all our jobs are going to disappear due to
automation and AI :)
Probably, there is a bug in Tidy Bot. I'm just speculating here, but it might
be related to the fact that this header comes last in the list (it might be
off-by-one mistake or alike).
PS15, Line 152: options allows "
: "to keep
> Nit: option retains
PS15, Line 156: is not in effect
> Nit: has no effect
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>