Dan Burkert has posted comments on this change. Change subject: thirdparty: fix up libtool scripts if needed ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4512/2/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: Line 383: $TP_DIR/postflight.py This should be in the above if block, I think. It will certainly always fail on OS X, since there is no ldd or tsan. I think it may also fail if you do a "./build-thirdparty.sh uninstrumented" on a clean checkout. -- To view, visit http://gerrit.cloudera.org:8080/4512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id51c10d38984e892496621135634d21f3e2386ce Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
