Adar Dembo has posted comments on this change. Change subject: thirdparty: use libc++ instead libstdc++ for TSAN builds ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4511/2/CMakeLists.txt File CMakeLists.txt: Line 106: COMMAND ${THIRDPARTY_DIR}/build-if-necessary.sh > shouldn't this only be building the uninstrumented group by default, and th You're looking at the patches out-of-order; the dependency group patch comes _after_ this one. Sorry for not making that clear. http://gerrit.cloudera.org:8080/#/c/4511/2/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: Line 345: # Enable debug symbols so that stacktraces and linenumbers are available at > Are the platform standard libraries built with debug symbols? If so we may libstdc++ on my machine doesn't have debug symbols in it, no. -- To view, visit http://gerrit.cloudera.org:8080/4511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9e68126ae21e04469053009c5b3e4b588415895 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
