Dinesh Bhat has posted comments on this change. Change subject: [util] Fix a minor bug in AssertEventually() ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4566/1/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: Line 591: return false; > Hmm. If we add a new PredicateType but forget to update this function, coul Sure, added FATAL under default case, I guess can't get around without a return bool value here to avoid this warning. http://gerrit.cloudera.org:8080/#/c/4566/1/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: Line 189: while (MonoTime::Now() < deadline) { > Might be simpler as a for loop that initializes attempts to 0, checks the d Done -- To view, visit http://gerrit.cloudera.org:8080/4566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id34b3461164d96261e4a2d1657244332eb33ad0c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
