Alexey Serbin has posted comments on this change.

Change subject: [c++ client] added few deprecation notes
......................................................................


Patch Set 1:

(1 comment)

> (1 comment)
 > 
 > Shouldn't we wait until the new API lands before deprecating the
 > old one though?

That's a good question.

The original intention for this change was to warn users of the API about the 
anticipated changes (as David mentioned in HipChat channel).

We could just add a notice, warning or attention (@notice, @warning and 
@attention in Doxygen lingo) as comments, but I thought if were  about to 
deprecate the methods pretty soon, I could just add the deprecation note along 
with corresponding clang/gcc attribute.

It would be nice to collect more feedback on this.

http://gerrit.cloudera.org:8080/#/c/4569/1/src/kudu/client/client.h
File src/kudu/client/client.h:

PS1, Line 396: its
> Nit: "in signature". Or maybe just "or change in a future release"
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45b797fa459ac9d214bb2612fd797f7a1eea45
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to