Adar Dembo has posted comments on this change. Change subject: rpc: Add min / max negotiation threads ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4574/1//COMMIT_MSG Commit Message: PS1, Line 9: it would be : helpful for users to be able to specify the minimum and maximum number : of threads in that pool I can see how this can be useful to reduce flakiness in TSAN-based tests (as you did in disk_reservation-itest), but how is it useful beyond that? Besides, I thought you were going to address the flakiness by just increasing FLAGS_rpc_negotiation_timeout_ms. Why this approach instead? Neither are particularly invasive, but tweaking an existing flag seems simpler and more predictable than prespawning threads (for the purpose of working around TSAN slow thread creation). PS1, Line 13: labelled http://grammarist.com/spelling/label You move to London and this is what happens? -- To view, visit http://gerrit.cloudera.org:8080/4574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife98b39d5f3a340702151ab27dc8026c8bac12ac Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
